test(pkg): incorrect dune resolved from PATH #12698
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ali Caglayan <[email protected]>
Alizter
changed the title
Alizter
commented
Nov 7, 2025
|
|
||
| $ mkpkg bar <<EOF | ||
| > depends: [ "dune" ] | ||
| > build: [ "echo" "$(which dune)" ] |
Collaborator
Author
There was a problem hiding this comment.
This might not be the most optimal way to test for this. One other issue is that we might just intercept (run dune ...) in the build plan and use our own, and that doesn't appear to be the case at the moment.
Member
|
Isn't this test enough already? #10020 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demonstrate the issue in #12697.